Skip to content

tests: use tmpdir fixture to avoid race #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ncopa wants to merge 1 commit into from
Closed

tests: use tmpdir fixture to avoid race #261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 8 additions & 22 deletions tests/test_dotexport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,22 +9,10 @@
from .helper import with_setup

TESTPATH = dirname(__file__)
GENPATH = join(TESTPATH, "dotexport")
REFPATH = join(TESTPATH, "refdata")


def setup():
if not exists(GENPATH):
makedirs(GENPATH)


def teardown():
if exists(GENPATH):
rmtree(GENPATH)


@with_setup(setup, teardown)
def test_tree1():
def test_tree1(tmpdir):
"""Tree1."""
root = Node("root")
s0 = Node("sub0", parent=root)
Expand All @@ -36,12 +24,11 @@ def test_tree1():
s1c = Node("sub1C", parent=s1)
Node(99, parent=s1c)

RenderTreeGraph(root).to_dotfile(join(GENPATH, "tree1.dot"))
assert cmp(join(GENPATH, "tree1.dot"), join(REFPATH, "tree1.dot"))
RenderTreeGraph(root).to_dotfile(join(tmpdir, "tree1.dot"))
assert cmp(join(tmpdir, "tree1.dot"), join(REFPATH, "tree1.dot"))


@with_setup(setup, teardown)
def test_tree2():
def test_tree2(tmpdir):
"""Tree2."""
root = Node("root")
s0 = Node("sub0", parent=root, edge=2)
Expand All @@ -67,12 +54,11 @@ def edgeattrfunc(node, child):
edgeattrfunc=edgeattrfunc,
)

r.to_dotfile(join(GENPATH, "tree2.dot"))
assert cmp(join(GENPATH, "tree2.dot"), join(REFPATH, "tree2.dot"))
r.to_dotfile(join(tmpdir, "tree2.dot"))
assert cmp(join(tmpdir, "tree2.dot"), join(REFPATH, "tree2.dot"))


@with_setup(setup, teardown)
def test_tree_png():
def test_tree_png(tmpdir):
"""Tree to png."""
root = Node("root")
s0 = Node("sub0", parent=root)
Expand All @@ -84,4 +70,4 @@ def test_tree_png():
s1c = Node("sub1C", parent=s1)
Node("sub1Ca", parent=s1c)

RenderTreeGraph(root).to_picture(join(GENPATH, "tree1.png"))
RenderTreeGraph(root).to_picture(join(tmpdir, "tree1.png"))