Implement GCFunction Logical Operations#50
Implement GCFunction Logical Operations#50google-labs-jules[bot] wants to merge 2 commits intogc-logical-ops-1112from
Conversation
This commit implements the GCFunction logical operations for the X11 server. It uses a dual-path approach: - Native canvas `globalCompositeOperation` is used for operations that have a direct equivalent (`Clear`, `Copy`). - Software emulation is used for all other logical operations, including `Xor`, due to inconsistencies in the browser's native implementation. A comprehensive visual test suite has been added to `go/internal/x11/visual_test.go` to validate the implementation of all 16 logical operations. The software emulation path has been optimized to only process the bounding box of the drawing operation, which resolves the performance issues that were causing test timeouts.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
This commit implements the GCFunction logical operations for the X11 server. It uses a dual-path approach: - Native canvas `globalCompositeOperation` is used for operations that have a direct equivalent (`Clear`, `Copy`). - Software emulation is used for all other logical operations, including `Xor`, due to inconsistencies in the browser's native implementation. A comprehensive visual test suite has been added to `go/internal/x11/visual_test.go` to validate the implementation of all 16 logical operations. The software emulation path has been optimized to only process the bounding box of the drawing operation, which resolves the performance issues that were causing test timeouts.
1 participant
This submission implements the GCFunction logical operations, including a comprehensive test suite and performance optimizations.
Fixes #
PR created automatically by Jules for task 14634334743299964314 started by @rthellend