Add GC Visual Tests and Anti-Aliasing Fix#51
Add GC Visual Tests and Anti-Aliasing Fix#51google-labs-jules[bot] wants to merge 1 commit intox11-checkpoint-20251105from
Conversation
Adds a new test suite, `TestGCComponents`, to `go/internal/x11/visual_test.go` to exercise various Graphics Context attributes. This includes tests for: - `LineWidth` - `CapStyle` (Butt, Projecting, Round) - `JoinStyle` (Miter, Bevel, Round) - `Clipping` During development, a browser anti-aliasing issue was discovered in the headless test environment, causing lines to be rendered with unexpected colors (e.g., gray instead of black), leading to test failures. To resolve this, all stroked drawing operations (where `LineWidth` > 0) are now forced through the software emulation path in `go/internal/x11/x11_frontend_wasm.go`. This provides pixel-perfect control and bypasses the browser's native rendering, ensuring consistent and correct test results.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
1 participant
This change introduces a new visual test suite for Graphics Context (GC) components and includes a necessary fix to address an anti-aliasing issue discovered during testing. The new tests in
go/internal/x11/visual_test.gocoverLineWidth,CapStyle,JoinStyle, andClipping, improving test coverage for the X11 frontend. The fix ingo/internal/x11/x11_frontend_wasm.goensures rendering consistency by forcing stroked operations into a software emulation path.Fixes #
PR created automatically by Jules for task 16316101964137101544 started by @rthellend