Fix: Allow Re-adding Deleted Team Members (Bug #73) & Modernize Build System#77
Open
RamatjyotSingh wants to merge 10 commits into
Open
Fix: Allow Re-adding Deleted Team Members (Bug #73) & Modernize Build System#77RamatjyotSingh wants to merge 10 commits into
RamatjyotSingh wants to merge 10 commits into
Conversation
Add pull request template.
- Switched from deprecated JCenter to MavenCentral - Applied gradle.properties workaround to keep R.id constants working with Gradle 8+ - Still targeting SDK 27 — upgrade pending proper refactor - TODO: clean up switch-case logic using R.id to future-proof the code
chore: updated dependencies, replaced JCenter, patched R.id issue
…giving an error
…without giving an error" Accidently pushed directly to master branch. This reverts commit 36f3299.
- Fixes compiler warnings about obsolete Java 8 source/target - Prepares codebase for future JDK compatibility - Part of ongoing build system modernization
This reverts commit da87cc1.
deleted members can now be readded without giving any error
…ed-members fix: resolved caarmen#73
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR modernizes the Gradle build system to fix a critical error with BuildConfig class generation, while maintaining compatibility with existing devices. It also fixes bug #73 which prevented re-adding deleted team members.
Major changes
Fixed BuildConfig generation: Resolved the "cannot find symbol BuildConfig" error by adding the explicit
buildConfig trueflag and proper namespace configuration, which is required by newer Android Gradle Plugin versionsUpgraded build tools:
Updated compilation environment:
Repository migrations:
Build performance improvements:
Bug fix Adding deleted user again into the team list. #73: Fixed the issue preventing re-adding deleted members
Why these changes are necessary
The app was failing to build due to missing BuildConfig class, which is essential for AboutActivity and other components. Modern AGP requires explicit configuration for BuildConfig generation which these changes provide.
These updates ensure compatibility with newer Android Studio versions and development environments while maintaining the same runtime behavior and device compatibility as before.
The bug fix addresses user frustration when trying to re-add previously deleted team members, improving the overall user experience.
Screenshots
Initial team screen
On deleting Ashley from team a
On re-adding Ashley you can see it doesn't give the error that team member already exists
When trying to add the same member again it gives error, thus no functionality is compromised
Quality checklist