Refactor write_tcl_script#30
Open
ftclark3 wants to merge 14 commits into
Open
Conversation
…r single and pair, as promised in the function type hints
…anchor them to CA positions rather than fixed coordinates; source the script in the tk console following alignment to move the lines along with the molecule
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I would like to refactor
frustration.write_tcl_script()to accomplish three goals:maskand/ordistance_matrixarguments may be instances of @cabb99's newSparseMatrixclass. In the present state of this branch, all sparse matrices are converted to dense matrices. This is probably fine. The biggest memory issue has always been the Potts model, which basically requires 20x20=400 of these square 2D distance matrix/mask arrays. However, I did add some code toSparseMatrixandwrite_tcl_script()to get us started if we want to work directly with sparse matrices in the future.graphicscommand instead ofdraw. It can now draw a full frustratogram for NFKB (615 residues) in fractions of a secondQuestions
SparseMatrixinwrite_tcl_script(): handle directly or always convert to dense? Based on our discussion today, we want to try to directly handle sparse matrices. I should check this further.vmd traj -e frustration.tcl, then the lines are drawn based on the final frame. We decided that this is okayStatus
write_tcl_scriptand make it the default behavior