Disable fail-fast to expose all matrix job failures#44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The openswoole 4.12.1 build is failing because
lang-php(Heroku's upstream S3 bucket) no longer allows anonymousListObjectsrequests. The build uses a wildcard dep (php-8.2.*) which causes bob to callListObjects— now blocked withAccessDenied.With
fail-fast: true, the openswoole 4.12.1 job (a standaloneincludematrix entry that skips all other extension builds) fails quickly and cancels all other in-progress jobs before they reach the same broken dep lookup. This makes it appear as though only openswoole is affected.Disabling
fail-fastwill let all jobs run to completion so we can confirm how many are actually broken before applying a fix.