Redact API token in Provision error message#132
Open
leonbeckert wants to merge 1 commit intocaddy-dns:masterfrom
Open
Redact API token in Provision error message#132leonbeckert wants to merge 1 commit intocaddy-dns:masterfrom
leonbeckert wants to merge 1 commit intocaddy-dns:masterfrom
Conversation
The fmt.Errorf in Provision() currently includes the raw API token when validation fails. This leaks the bearer into container logs (via `docker logs`), which is a credential exposure risk. Add a redactToken() helper that shows only the first 8 and last 4 characters, masking the middle with asterisks. Add tests for both the redaction function itself and the Provision error path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
fmt.ErrorfinProvision()currently includes the raw API token when validation fails:This leaks the bearer into container logs (via
docker logs), which is a credential exposure risk in containerized deployments.This PR adds a
redactToken()helper that shows only the first 8 and last 4 characters, masking the middle with asterisks:Changes
cloudflare.go: AddredactToken()helper, use it in theProvisionerror pathcloudflare_test.go: AddTestProvisionErrorRedactsToken(asserts full token does NOT appear in error) andTestRedactToken(6 table-driven cases covering empty, short, boundary, legacy, and cfat_ tokens)Notes