test: Validate typing in tests#62
Merged
natemort merged 1 commit intocadence-workflow:mainfrom Jan 21, 2026
Merged
Conversation
While somewhat painful, type checking our tests should help ensure that what we build is idiomatic. This validates that the typing information we provide on our public functions is correct and usable. Change mypy to be run directly rather than as a tool. Running it as a tool executes it independently of the version that we configure and made it not correctly resolve pytest. The uv documentation lists mypy as an example to use "uv run" rather than "uv tool run". As part of enabling this, disable type checking for specific lines that need additional work in the library to correct the type checking. This is particularly around Workflow and Activity Definitions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While somewhat painful, type checking our tests should help ensure that what we build is idiomatic. This validates that the typing information we provide on our public functions is correct and usable.
Change mypy to be run directly rather than as a tool. Running it as a tool executes it independently of the version that we configure and made it not correctly resolve pytest. The uv documentation lists mypy as an example to use "uv run" rather than "uv tool run".
As part of enabling this, disable type checking for specific lines that need additional work in the library to correct the type checking. This is particularly around Workflow and Activity Definitions.
What changed?
uv runrather than as a toolwarn_unused_ignores. For some reason the prometheus packages keep flaking on this, I don't know what's wrong with my local setup.Why?
How did you test it?
Potential risks
Release notes
Documentation Changes