feat: define python client search attribute types#66
Open
timl3136 wants to merge 2 commits intocadence-workflow:mainfrom
Open
feat: define python client search attribute types#66timl3136 wants to merge 2 commits intocadence-workflow:mainfrom
timl3136 wants to merge 2 commits intocadence-workflow:mainfrom
Conversation
Signed-off-by: Tim Li <ltim@uber.com>
shijiesheng
reviewed
Feb 6, 2026
| CADENCE_CHANGE_VERSION = "CadenceChangeVersion" | ||
|
|
||
|
|
||
| class SearchAttributeConverter: |
Member
There was a problem hiding this comment.
we don't need this. My understanding is we only expose APIs like UpsertSearchAttributes. We can use python generics to get the type hints and thus use the dataconverter for actual convertion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
defined the search attribute types in python client
Why?
in order to use search attribute in client, we need proper typing for search attributes.
How did you test it?
Unit test, it's not integrated with client yet.
Potential risks
Release notes
Documentation Changes