Activated Sludge Model ASM3h#413
Draft
cbix wants to merge 63 commits into
Draft
Conversation
…into feature/ActiveSludgeModel3
…into feature/ActiveSludgeModel3
…into feature/ActiveSludgeModel3
AntoniaBerger
force-pushed
the
feature/ActiveSludgeModel3
branch
from
9b99534 to
de0973f
Compare
AntoniaBerger
force-pushed
the
feature/ActiveSludgeModel3
branch
from
de8c6b2 to
3b27b96
Compare
AntoniaBerger
force-pushed
the
feature/ActiveSludgeModel3
branch
3 times, most recently
from
58980c2 to
f68248d
Compare
AntoniaBerger
force-pushed
the
feature/ActiveSludgeModel3
branch
3 times, most recently
from
e0a12b8 to
42c8de7
Compare
AntoniaBerger
force-pushed
the
feature/ActiveSludgeModel3
branch
from
735f7f8 to
fa1149d
Compare
…ture/ActiveSludgeModel3
Add documentation Add option to deactive active aeration Update documentation for the active Aeration update documentation Update Extention Update documentation for extention
skip zero values in jacobian
jbreue16
reviewed
Apr 21, 2026
Contributor
jbreue16
left a comment
jbreue16
left a comment
There was a problem hiding this comment.
From my understanding, this is not planned to be merged anymore? In that case we should document that somewhere.
I think we should have a central place where we list features and their branches which did not make it to master but are saved as (non-maintained) feature code. Maybe have some noMerge/featureName branches and a list in the documentation?
@schmoelder , @AntoniaBerger what are your thoughts?
Contributor
|
AFAIK, Antonia is still working on it and is making good progress. 🤓 |
Collaborator
|
Yes I am working with and on it, I will merge as soon, I have finalised the simulation results. |
Contributor
|
ok, pardon me |
AntoniaBerger
force-pushed
the
feature/ActiveSludgeModel3
branch
from
fa1149d to
04093d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an implementation of the Activated Sludge Model 3 in the ASM3h variant as used by SIMBA#.
Activated Sludge Models are mostly used in modelling biological processes in wastewater treatment plants.
TODO