Skip to content

Update NSI oscillation source files, add stan support#45

Open
xiaoyan1997 wants to merge 4 commits into
cafana:mainfrom
xiaoyan1997:feature/xhuang6_oscillib_stan
Open

Update NSI oscillation source files, add stan support#45
xiaoyan1997 wants to merge 4 commits into
cafana:mainfrom
xiaoyan1997:feature/xhuang6_oscillib_stan

Conversation

@xiaoyan1997
Copy link
Copy Markdown

No description provided.

@xiaoyan1997 xiaoyan1997 requested a review from a team as a code owner April 28, 2026 20:31
Comment thread OscLib/OscCalcPMNS_NSI.cxx Outdated
Copy link
Copy Markdown
Contributor

@chenel chenel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working with me on this.

I noticed one other thing, which is not your fault because it's from the preceding calculator code, but which needs to be addressed ASAP:

_OscCalcPMNS_NSI doesn't override GetParamsHash() from the base class. That means it inherits GetParamsHashDefault from _IOscCalcAdjustable, which only hashes the 8 standard oscillation parameters: fL, fRho, fDmsq21, fDmsq32, fTh12, fTh13, fTh23, fdCP (see IOscCalc.cxx:87-90). The 9 NSI-specific members (fEps_ee, ...) are silently excluded.
This means that any cache pull using GetParamsHash() will return stale results when only NSI parameters change---i.e., you'll get the same prediction for differing NSI parameters (😱).

We need an overridden GetParamsHash() in this class. Are you game for implementing it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants