WIP: FEA Quantile regression for decision trees#1
Draft
Conversation
…dded print everywhere to debug; fixed some bugs
…al PR but not all
Naming & comments Co-authored-by: Adam Li <adam2392@gmail.com>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
…to mae-split-optim
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
Follow up to PR scikit-learn#32100 and esp. discussion here: scikit-learn#32100 (comment)
TODO (bottom-up order):
test_absolute_errors_precomputation_function(now renamedtest_pinball_loss_precomputation_function)test_absolute_errors_precomputation_functionmakes me already fairly confident):Reference Issues/PRs
scikit-learn#32100
What does this implement/fix? Explain your changes.
Any other comments?
Maths:
We consider a weighted dataset${(y_i, w_i)}_{i}$ with non-negative weights $w_i$ .
For a scalar prediction$q$ , the weighted pinball loss is
Equivalently, splitting by whether$y_i \ge q$ or $y_i < q$ :
To evaluate this efficiently, introduce the aggregates
Using these, the loss admits the "O(1)" form
Or in the code: