Skip to content

fix(i18n): add missing space before Hebrew duration abbreviation#29773

Open
Emran-Y wants to merge 1 commit into
calcom:mainfrom
Emran-Y:fix/hebrew-duration-space
Open

fix(i18n): add missing space before Hebrew duration abbreviation#29773
Emran-Y wants to merge 1 commit into
calcom:mainfrom
Emran-Y:fix/hebrew-duration-space

Conversation

@Emran-Y

@Emran-Y Emran-Y commented Jul 14, 2026

Copy link
Copy Markdown

What does this PR do?

Fixes #29694

The Hebrew locale duration abbreviations were missing a space between the number and the abbreviated unit (e.g. 15ד׳ instead of 15 ד׳). This caused screen readers to misread the duration and made the booking page duration text harder to read.

Changes:

  • minute_one_short: added space → {{count}} ד׳
  • hour_one_short: added space → {{count}} ש׳

Screenshot

See issue #29694 for visual evidence.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  1. Open Cal.com booking page in Hebrew locale
  2. Verify duration shows with a space between the number and abbreviation (e.g. "15 דק instead of 15דק")

…com#29694)

The Hebrew locale was missing a space between the number and the minute/hour
short form abbreviation (e.g. "15ד׳" instead of "15 ד׳"). This caused
screen readers to pronounce the duration incorrectly ("15 metres") and
made the booking page duration text difficult to read.

Also fixes the same issue for hour_one_short.
@github-actions

Copy link
Copy Markdown
Contributor

Welcome to Cal.diy, @Emran-Y! Thanks for opening this pull request.

A few things to keep in mind:

  • This is Cal.diy, not Cal.com. Cal.diy is a community-driven, fully open-source fork of Cal.com licensed under MIT. Your changes here will be part of Cal.diy — they will not be deployed to the Cal.com production app.
  • Please review our Contributing Guidelines if you haven't already.
  • Make sure your PR title follows the Conventional Commits format.

A maintainer will review your PR soon. Thanks for contributing!

@github-actions github-actions Bot added the 🐛 bug Something isn't working label Jul 14, 2026
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e3b59722-8a52-4055-af4c-a8fa8dea204c

📥 Commits

Reviewing files that changed from the base of the PR and between f004349 and 7527ba5.

📒 Files selected for processing (1)
  • packages/i18n/locales/he/common.json

📝 Walkthrough

Walkthrough

The Hebrew locale’s singular short labels for minutes and hours now include a space between {{count}} and their abbreviations.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding a missing space in Hebrew duration abbreviations.
Description check ✅ Passed The description matches the code changes and links them to the Hebrew duration spacing bug.
Linked Issues check ✅ Passed The locale string updates address the linked Hebrew duration spacing issue in the booking page.
Out of Scope Changes check ✅ Passed The PR only adjusts the Hebrew locale duration strings, with no unrelated code changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hebrew duration space

1 participant