fix(i18n): add missing space before Hebrew duration abbreviation#29773
Open
Emran-Y wants to merge 1 commit into
Open
fix(i18n): add missing space before Hebrew duration abbreviation#29773Emran-Y wants to merge 1 commit into
Emran-Y wants to merge 1 commit into
Conversation
…com#29694) The Hebrew locale was missing a space between the number and the minute/hour short form abbreviation (e.g. "15ד׳" instead of "15 ד׳"). This caused screen readers to pronounce the duration incorrectly ("15 metres") and made the booking page duration text difficult to read. Also fixes the same issue for hour_one_short.
Contributor
|
Welcome to Cal.diy, @Emran-Y! Thanks for opening this pull request. A few things to keep in mind:
A maintainer will review your PR soon. Thanks for contributing! |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Hebrew locale’s singular short labels for minutes and hours now include a space between 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #29694
The Hebrew locale duration abbreviations were missing a space between the number and the abbreviated unit (e.g.
15ד׳instead of15 ד׳). This caused screen readers to misread the duration and made the booking page duration text harder to read.Changes:
minute_one_short: added space →{{count}} ד׳hour_one_short: added space →{{count}} ש׳Screenshot
See issue #29694 for visual evidence.
Type of change
How should this be tested?