perf: batch task deletion in cancelNoShowTasksForBooking#29776
Draft
Kadajett wants to merge 1 commit into
Draft
Conversation
Replace one deleteMany per booking with a single deleteMany using an 'in' filter on the booking uids. Same rows deleted, one query instead of N.
Contributor
|
Welcome to Cal.diy, @Kadajett! Thanks for opening this pull request. A few things to keep in mind:
A maintainer will review your PR soon. Thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
cancelNoShowTasksForBookingis called with a webhook, it issues oneprisma.task.deleteManyper booking inside aPromise.all— N queries for N bookings.A single
deleteManywithreferenceUid: { in: bookingUids }deletes the same rows in one query.No behavior change.