Skip to content

feat: add capabilities command#1133

Merged
thymikee merged 1 commit into
mainfrom
feat/capabilities-command
Jul 6, 2026
Merged

feat: add capabilities command#1133
thymikee merged 1 commit into
mainfrom
feat/capabilities-command

Conversation

@thymikee

@thymikee thymikee commented Jul 6, 2026

Copy link
Copy Markdown
Member

Summary

Add a capabilities inventory command that reports target-supported command names as availableCommands.
Expose the command through CLI output, the daemon inventory route, and client.devices.capabilities().
Document the CLI and Node API surfaces for dynamic integrations.

Validation

  • pnpm exec vitest run src/daemon/handlers/__tests__/session-capabilities.test.ts src/daemon/__tests__/daemon-command-registry.test.ts src/core/command-descriptor/__tests__/parity.test.ts src/commands/__tests__/command-surface-metadata.test.ts src/utils/__tests__/command-schema-guards.test.ts
  • pnpm exec vitest run src/cli/parser/__tests__ src/utils/__tests__/command-schema-guards.test.ts
  • pnpm check:quick
  • Unit projects from pnpm check:unit passed: 362 files, 3270 tests
  • pnpm build
  • pnpm test:smoke

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-07-06 17:36 UTC

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
JS raw 1.5 MB 1.5 MB -3.9 kB
JS gzip 496.1 kB 494.5 kB -1.6 kB
npm tarball 591.9 kB 590.5 kB -1.4 kB
npm unpacked 2.1 MB 2.1 MB -3.7 kB

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 27.3 ms 27.3 ms +0.0 ms
CLI --help 50.7 ms 51.2 ms +0.5 ms

Top changed chunks:

Chunk Raw diff Gzip diff
dist/src/session.js -728 B -245 B
dist/src/command-metadata.js +723 B +191 B
dist/src/internal/daemon.js -794 B -165 B
dist/src/cli-help.js +195 B +65 B
dist/src/record-trace-recording.js +119 B +65 B

@thymikee thymikee force-pushed the feat/capabilities-command branch from 555b9eb to 897baf8 Compare July 6, 2026 15:40
@thymikee

thymikee commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

CI failure is actionable, not a flake.

Current failing checks on #1133:

The provider integration leak guard is failing because the new public command is not classified:

Public command "capabilities" is neither driven nor skipped. Add it to DRIVEN_COMMANDS (preferred) or SKIPPED_COMMANDS in apple-platform-output-guard.test.ts so it can't escape the apple-leak guard.

Please add capabilities to the guard coverage (preferred: drive it if it returns public command output; otherwise explicitly skip with a short reason) so it cannot leak internal apple platform strings.

@thymikee thymikee force-pushed the feat/capabilities-command branch from b51e77d to 3408a8f Compare July 6, 2026 17:02
@thymikee

thymikee commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

Reviewed #1133 at head 3408a8f. No blockers found.

What I checked:

  • command surface: capabilities is wired through the management command family, CLI schema/help, daemon writer, client API, and website docs
  • daemon route: inventory handler requires an existing session or explicit selector, resolves the target without booting stopped Android AVD placeholders, returns publicDeviceInfo, and filters command names through the existing capability matrix
  • routing/policy: descriptor and daemon-registry tests cover inventory route, lease/lock exemptions, selector exemption, explicit-device preference, and batch exposure
  • regression from the earlier CI failure: provider guard now includes capabilities, and Integration/Coverage are green

All 22 checks are passing. Residual risk is low: this is an inventory/control-plane command with provider-backed policy coverage; no live-device-only behavior changed.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Jul 6, 2026
@thymikee thymikee merged commit db69124 into main Jul 6, 2026
22 checks passed
@thymikee thymikee deleted the feat/capabilities-command branch July 6, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant