refactor: extract host process primitives#1134
Merged
Merged
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
7ad2ae7 to
cc9000d
Compare
cc9000d to
472c98b
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract shared host process primitives after the managed web browser cleanup landed.
Move daemon identity and takeover checks into a daemon-owned module, keep browser/runner/app-log/trace cleanup policy at the call sites, and migrate matching callers/tests away from
process-identity.ts.Validation
pnpm formatnode ./node_modules/oxfmt/bin/oxfmt --check scripts/clean-daemon.tspnpm check:quickpnpm buildpnpm test:smokepnpm check:fallow --base origin/mainpnpm check:unitfull-suite reruns hit the existing Apple status-bar timing/contention failure insrc/platforms/apple/core/__tests__/index.test.ts; that file passed in isolation with 96 tests