Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/frank-chairs-grin.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'brownfield': minor
'@callstack/brownfield-cli': minor
'@callstack/react-native-brownfield': minor
---

feat: strip SO files by default, deprecate experimental option in favor of useStrippedSoFiles
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ class JNILibsProcessor : BaseProject() {
for (archiveLibrary in aarLibraries) {
val jniDir = archiveLibrary.getJniDir()
processNestedLibs(jniDir.listFiles(), existingJNILibs)
if (projectExt.experimentalUseStrippedSoFiles) {
if (projectExt.useStrippedSoFiles) {
copyStrippedSoLibs(variant, existingJNILibs)
} else {
Comment on lines 54 to 58
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may address this in a follow-up PR.
CC @hurali97

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add it to the bench

if (jniDir.exists()) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,28 @@ open class Extension {
* List of dynamic libs (.so) files that you wish to bundle with
* the aar.
*
* By default only `libappmodules.so` and `libreact_codegen_*.so` are
* By default, only `libappmodules.so` and `libreact_codegen_*.so` are
* bundled.
*/
var dynamicLibs = listOf<String>()

/**
* Whether to use stripped .so files.
*
* Default value is `false`
* Default is `true`.
*/
var experimentalUseStrippedSoFiles = false
var useStrippedSoFiles = true

@Deprecated(
message =
"This property is deprecated and will be removed in a future release." +
"The successor is useStrippedSoFiles, which is by default true.",
replaceWith = ReplaceWith("useStrippedSoFiles"),
level = DeprecationLevel.WARNING,
)
var experimentalUseStrippedSoFiles
get() = useStrippedSoFiles
set(value) {
useStrippedSoFiles = value
}
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

plugins {
id("com.android.library")
id("org.jetbrains.kotlin.android")
Expand Down
Loading