Skip to content

fix: maestro tests improvements#1095

Merged
troZee merged 3 commits into
masterfrom
fix/maestro-ltr-tests
Jul 8, 2026
Merged

fix: maestro tests improvements#1095
troZee merged 3 commits into
masterfrom
fix/maestro-ltr-tests

Conversation

@troZee

@troZee troZee commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS ✅❌
Android ✅❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR focuses on improving Maestro E2E reliability/organization for the example app by introducing reusable setup sub-flows, expanding which Maestro suites get executed, and making a couple of UI/test-runner adjustments to reduce flakiness.

Changes:

  • Extracted repeated “launch + navigate to example” steps into new .maestro/setup/*_setup.yaml flows and updated tests to runFlow them.
  • Updated the Maestro runner script to use shorter retry delays and to include RTL tests.
  • Made RTL flows more defensive around the LTR toggle; adjusted example app UI/log handling to better support E2E.

Reviewed changes

Copilot reviewed 12 out of 19 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
scripts/run-maestro-tests.sh Shorter retry delays; include RTL test directory in discovered suites.
example/src/tabView/TabViewInsideScrollViewExample.tsx Layout tweak (header height) that may affect test interaction/visibility.
example/index.js Suppresses LogBox output globally.
.maestro/tests/tab_view_inside_scroll_view_example.yaml Uses new setup flow via updated runFlow path.
.maestro/tests/scrollable_pagerView_example.yaml Uses new setup flow via updated runFlow path.
.maestro/tests/pager_vertical_basic_example.yaml Uses new setup flow via updated runFlow path.
.maestro/tests/pager_basic_example.yaml Uses new setup flow via updated runFlow path.
.maestro/tests/on_page_selected_example.yaml Uses new setup flow via updated runFlow path.
.maestro/tests/nested_pagerView_example.yaml Uses new setup flow via updated runFlow path.
.maestro/tests/material_top_bar_example.yaml Uses new setup flow via updated runFlow path.
.maestro/tests/rtl/pager_vertical_basic_example_rtl.yaml Makes the LTR tap conditional to avoid failing when not present.
.maestro/tests/rtl/pager_basic_example_rtl.yaml Makes the LTR tap conditional to avoid failing when not present.
.maestro/setup/tab_view_inside_scroll_view_example_setup.yaml New reusable setup flow for TabView-inside-ScrollView test.
.maestro/setup/scrollable_pagerView_example_setup.yaml New reusable setup flow for Scrollable PagerView test.
.maestro/setup/pager_vertical_basic_example_setup.yaml New reusable setup flow for Vertical Basic Example test.
.maestro/setup/pager_basic_example_setup.yaml New reusable setup flow for Basic Example test.
.maestro/setup/on_page_selected_example_setup.yaml New reusable setup flow for OnPageSelected test.
.maestro/setup/nested_pagerView_example_setup.yaml New reusable setup flow for Nested PagerView test.
.maestro/setup/material_top_bar_example_setup.yaml New reusable setup flow for MaterialTopBar test.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread example/index.js
@troZee troZee merged commit 378370e into master Jul 8, 2026
7 checks passed
@troZee troZee deleted the fix/maestro-ltr-tests branch July 8, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants