fix: maestro tests improvements#1095
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR focuses on improving Maestro E2E reliability/organization for the example app by introducing reusable setup sub-flows, expanding which Maestro suites get executed, and making a couple of UI/test-runner adjustments to reduce flakiness.
Changes:
- Extracted repeated “launch + navigate to example” steps into new
.maestro/setup/*_setup.yamlflows and updated tests torunFlowthem. - Updated the Maestro runner script to use shorter retry delays and to include RTL tests.
- Made RTL flows more defensive around the
LTRtoggle; adjusted example app UI/log handling to better support E2E.
Reviewed changes
Copilot reviewed 12 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/run-maestro-tests.sh | Shorter retry delays; include RTL test directory in discovered suites. |
| example/src/tabView/TabViewInsideScrollViewExample.tsx | Layout tweak (header height) that may affect test interaction/visibility. |
| example/index.js | Suppresses LogBox output globally. |
| .maestro/tests/tab_view_inside_scroll_view_example.yaml | Uses new setup flow via updated runFlow path. |
| .maestro/tests/scrollable_pagerView_example.yaml | Uses new setup flow via updated runFlow path. |
| .maestro/tests/pager_vertical_basic_example.yaml | Uses new setup flow via updated runFlow path. |
| .maestro/tests/pager_basic_example.yaml | Uses new setup flow via updated runFlow path. |
| .maestro/tests/on_page_selected_example.yaml | Uses new setup flow via updated runFlow path. |
| .maestro/tests/nested_pagerView_example.yaml | Uses new setup flow via updated runFlow path. |
| .maestro/tests/material_top_bar_example.yaml | Uses new setup flow via updated runFlow path. |
| .maestro/tests/rtl/pager_vertical_basic_example_rtl.yaml | Makes the LTR tap conditional to avoid failing when not present. |
| .maestro/tests/rtl/pager_basic_example_rtl.yaml | Makes the LTR tap conditional to avoid failing when not present. |
| .maestro/setup/tab_view_inside_scroll_view_example_setup.yaml | New reusable setup flow for TabView-inside-ScrollView test. |
| .maestro/setup/scrollable_pagerView_example_setup.yaml | New reusable setup flow for Scrollable PagerView test. |
| .maestro/setup/pager_vertical_basic_example_setup.yaml | New reusable setup flow for Vertical Basic Example test. |
| .maestro/setup/pager_basic_example_setup.yaml | New reusable setup flow for Basic Example test. |
| .maestro/setup/on_page_selected_example_setup.yaml | New reusable setup flow for OnPageSelected test. |
| .maestro/setup/nested_pagerView_example_setup.yaml | New reusable setup flow for Nested PagerView test. |
| .maestro/setup/material_top_bar_example_setup.yaml | New reusable setup flow for MaterialTopBar test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.md