chore: linter rules to detect forwardRef usage#3632
Merged
lukewalczak merged 3 commits intocallstack:mainfrom Feb 6, 2023
Merged
chore: linter rules to detect forwardRef usage#3632lukewalczak merged 3 commits intocallstack:mainfrom
forwardRef usage#3632lukewalczak merged 3 commits intocallstack:mainfrom
Conversation
|
Hey @DimitarNestorov, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
lukewalczak
reviewed
Feb 2, 2023
DimitarNestorov
force-pushed
the
chore/react-forwardref-eslint-rule
branch
from
8311151 to
2872c9f
Compare
lukewalczak
approved these changes
Feb 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I noticed that I missed to remove
React.forwardReffrom some places when working on #3603 so I decided to make a couple of ESLint rulesTest plan
CI passes