fix: support portable zip install-source extraction#401
Merged
Conversation
|
thymikee
force-pushed
the
codex/install-source-unzip-fallback
branch
from
61310a4 to
61386b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use
unzipfor install-source zip extraction instead ofditto, including direct.ipaextraction. This removes the macOS-only extractor dependency from the zip-like install-source flow and keeps Linux/remote bridge environments working whenunzipis available.Add regression coverage that exposes
unzipwithoutdittoinPATHand verifiesmaterializeInstallablePathcan extract a nested.apk. Update Android/iOS install fixtures to use real zip archives orunzipshims instead ofdittoshims.Touched files: 5. Scope stayed within install-source and install artifact extraction coverage.
Validation
unzip -v | sed -n '1,3p'\npnpm exec vitest run src/platforms/__tests__/install-source.test.ts\npnpm exec vitest run src/platforms/__tests__/install-source.test.ts src/platforms/android/__tests__/index.test.ts src/platforms/ios/__tests__/index.test.ts\npnpm format\npnpm check:quick\npnpm check:unit\n\nDocs/skills were not updated because this is an implementation fix with no CLI flag, workflow, or usage-contract change.