feat(sqlite-plugin): export shared adapter helpers from main package entry#226
Open
Mohamed-kassim wants to merge 2 commits intocallstackincubator:mainfrom
Open
Conversation
…bpath Made-with: Cursor
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Drop ./internals subpath and the extra Vite entry; export shared SQL and bridge helpers from react-native.ts alongside createSqliteAdapter. Made-with: Cursor
Mohamed-kassim
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We’re using react-native-nitro-sqlite with the Rozenite SQLite inspector instead of Expo’s SQLite API. The plugin already contains the SQL normalization, statement classification, bridge param decoding, and error formatting logic we need, but that code wasn’t part of the public package surface, so the practical alternative was to duplicate it in our app.
So we can implement a
createSqliteAdapter-compatible driver without copying or reimplementing that pipeline.Exported symbols:
SqlStatementSegment(type),splitSqlStatements,normalizeSingleStatementSql,classifySqlStatement,statementReturnsRows,decodeSqliteBridgeValue,formatSqliteError(from existingsrc/shared/sqlandsrc/shared/bridge-values).Question for maintainers
We also have a small adapter that wires react-native-nitro-sqlite into
createSqliteAdapter, using these same helpers. Are you open to follow-up PRs that add additional first-party adapters (e.g. Nitro)?