Polish impact CLI output#28
Merged
Merged
Conversation
Replace verbose impact text output with a compact reporter-style summary, warning counts, and diagnostics path guidance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
This PR makes
sniffler impactoutput easier to scan in a terminal. Instead of printing every changed file, affected module, dependency path, and warning inline, the text reporter now presents selected E2E tests first and follows with a compact summary inspired by Vitest/Jest-style CLI output.How does it work?
The text renderer now formats each selected test with a status icon and a short reason using
depends on affectedlanguage. Summary rows report the number of selected tests, changed files, affected modules, and warnings. Warning details stay out of the default text output; when warnings exist, the CLI either suggests rerunning with--diagnosticsor shows.sniffler/diagnostics.jsonwhen diagnostics were produced. JSON output keeps the existing detailed structure for automation and debugging.Why is this useful?
The impact command now optimizes for the decision developers need to make first: which E2E tests should run. It still surfaces warning and diagnostics information, but without flooding normal CLI output with low-level graph details. Reviewers and CI users can keep using JSON output for full details, while humans get a cleaner terminal report.