This repository was archived by the owner on Nov 13, 2022. It is now read-only.
Added RFC-4733 DTMF support#27
Open
jonasclement wants to merge 5 commits into
Open
Conversation
added 5 commits
October 7, 2019 15:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're using react-sip for a project at our organization, and we needed DTMF support, so I took the liberty of adding it to react-sip.
Note that this is RFC-4733 DTMF, so DTMF in the RTP payload, rather than JsSip's SIP INFO implementation. This could be added, but doesn't fit our specific use case as we connect to PSTN providers who don't support SIP INFO (and therefore I won't be allocated time to do it 😞).