This repository was archived by the owner on Nov 13, 2022. It is now read-only.
Added the ability to choose a specific audio device#28
Open
jonasclement wants to merge 6 commits into
Open
Conversation
added 6 commits
October 8, 2019 13:21
Without these changes, the browser will throw a DOMException when changing devices if one or more calls have been made already. I narrowed it down the remoteAudio.srcObject not being reset post-call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added two new props to
<SipProvider>- incoming- and outboundAudioDeviceId. If these are passed to the SipProvider, it will use those devices for audio instead of the system default.Please note that you can not change audio devices while a call is in progress, and attempting to do so will drop the call.