Demo simplified and slightly expanded#6
Open
karaokeresearch wants to merge 12 commits intocalvinfo:masterfrom
Open
Demo simplified and slightly expanded#6karaokeresearch wants to merge 12 commits intocalvinfo:masterfrom
karaokeresearch wants to merge 12 commits intocalvinfo:masterfrom
Conversation
Switched out the complicated Express code in app.js for express.static middleware. Switched to port 80 to ease mobile testing. In the index.html, I use the version-independent syntax and ditch the standalone socket.io.js file in favor of having it served out by socket.io
Socket.io now complains if you don't disable logging via the DEBUG environmental variable. Also, there's no reason to specify Express 3.0.2. Streamlined syntax should work in pretty much any new version of Express.
…e >3 or 4 ms lag even on networks with <5ms lag, probably due to a less-than-robust wireless card, such as my Samsung Galaxy s2. This code takes the best 4 pings out of 20 and uses the data from those since lower pings = less margin for error. Still has tons of debug code in there, for now.
… seconds to save bandwidth!
…his fork no longer corrects it :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for writing this. Very useful piece of software. I have some proposed changes for the client:
Switched out the complicated Express code in app.js for express.static
middleware. Switched to port 80 to ease mobile testing.
In the index.html, I use the version-independent syntax and ditch the
standalone socket.io.js file in favor of having it served out by
socket.io