feat(app): add Korean (ko) locale support - #896
Open
moduvoice wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 4241448 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This adds Korean (
ko) translation support — to help Korean-speaking users use thisopen-source project more comfortably in their own language.
한국 사람들의 오픈소스 이용에 도움이 되게 하기 위해서 한글화 작업을 하였습니다.
Changes
packages/app/gatsby-config.js: registeredkoin thegatsby-plugin-react-i18nextlanguagesarray (['en', 'ja', 'ko'])packages/app/src/locales/ko/common.json(new): full Korean translation, 83/83 keys, 1:1 parity withen/ja(all{{version}}interpolation tokens,$t(...)cross-references, and<br>/<br />tags preserved in position and count)packages/app/src/locales/en/common.jsonandpackages/app/src/locales/ja/common.json: added"ko": "한국어"to thelanguagedisplay-name map.changeset/warm-lions-add.md: changeset for@viron/app(minor), following the repo's existing changeset conventionNo changes were needed in the language switcher component (
packages/app/src/components/app-sidebar.tsx) — it renders language options dynamically from thelanguagesarray provided by the i18n hook, so registeringkoingatsby-config.jsplus thelanguage.kokey is sufficient for it to appear automatically.Scope note:
example/nodejs/src/locales(a small demo backend locale, unrelated to the admin-dashboard UI i18n registry) andpackages/website/i18n(the separate Docusaurus documentation site, ~35 files) were intentionally left untouched, since this PR focuses on the admin-dashboard UI. Happy to follow up with either as a separate PR if maintainers want it.Testing
ko/common.json, 0 missing/extra vs bothenandja; all{{version}}tokens,$t(...)references, and<br>/<br />tags verified byte-identical in position/count.npx gatsby build(Node 22, perpackages/app'senginesfield) end-to-end: build succeeded, and the output underpublic/ko/*contains a full set of statically generated Korean routes (index, 404, endpoints, endpointimport, oauthredirect, oidcredirect, dashboard/endpoints, dashboard/groups, endpoints/[endpointId] — matching the existing/ja/*route count 1:1).public/index.html's language switcher<select>renders<option value="ko">한국어</option>alongsideen/ja, confirming the new locale is genuinely reachable in the built UI.eslint(workspace's ownnpm run lintinpackages/app): 0 errors, 112 warnings (pre-existing, unrelated to this change).prettier --checkon all changed files: passes.