Conversation
| RUN pip install -r requirements.txt | ||
| COPY . . | ||
|
|
||
| CMD ["python", "app.py"] No newline at end of file |
There was a problem hiding this comment.
There is a 'proper' way to run flask using the Flask CLI, which we could set as an entrypoint (and then pass in any args we want via docker-compose or manually running the container), but that's not strictly necessary.
At some point in the future we should rejig this (or have a separate production dockerfile) to use a WSGI server, see the flask docs on deployment
There was a problem hiding this comment.
The idea here is to 100% have a separate production dockerfile, so I'm happy running in debug here.
Flask API for running could be nicer I agree.
There was a problem hiding this comment.
It also looks like you can do some other nice things like custom commands that have access to app context which we might want to use in the future to make administering jacob easier. But I still think having a sane __name__="__main__" block for running without the CLI makes sense to have.
There was a problem hiding this comment.
That's probably going to be needed for "first time DB setup" (and migrations? but i'm gonna pretend we'll never need to do migrations)
2 participants
No description provided.