Conversation
…-164322 sync: main into develop
feat(simulation): tap token name to view contract address
📝 WalkthroughWalkthroughThis PR releases v1.1.4 with interactive token and collection details. Users can now tap token symbols, logos, and collection names in the transaction simulation screen to view address details in a bottom sheet. Supporting improvements include better error handling in the address detail sheet's URL launcher and Android manifest configuration for HTTPS intent handling. ChangesInteractive Token/Collection Details and v1.1.4 Release
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@lib/features/verify_safe_transaction/simulation/safe_tx_simulation_screen.dart`:
- Around line 266-275: The helper _showTokenDetail funnels taps into
AddressDetailSheet which assumes availableNetworks[chainId] exists and can crash
for unsupported/custom chains; before calling AddressDetailSheet, check that
widget.safeAccount.network.chainId is present in the networks map (or otherwise
supported) and only open the sheet when valid—if not, return early or show a
safe fallback (e.g., an error/snackbar) instead of opening AddressDetailSheet to
avoid the force-unwrap crash. Use the same chainId symbol
(widget.safeAccount.network.chainId) to locate the call site and gate it with a
containsKey/isSupported check against the app's network registry before creating
AddressDetailSheet.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 7eea5e21-3070-4183-a233-c1291207c6d8
📒 Files selected for processing (5)
CHANGELOG.mdandroid/app/src/main/AndroidManifest.xmllib/features/verify_safe_transaction/simulation/safe_tx_simulation_screen.dartlib/shared/widgets/address_detail_sheet.dartpubspec.yaml
Promote dev to main for Safe OpenSig 1.1.4
Includes the release commit from #87 plus merged changes since v1.1.3
Summary by CodeRabbit
New Features
Bug Fixes
Chores