Skip to content

release: promote 1.1.4#88

Merged
Sednaoui merged 5 commits into
mainfrom
develop
May 19, 2026
Merged

release: promote 1.1.4#88
Sednaoui merged 5 commits into
mainfrom
develop

Conversation

@andrewwahid
Copy link
Copy Markdown
Member

@andrewwahid andrewwahid commented May 19, 2026

Promote dev to main for Safe OpenSig 1.1.4
Includes the release commit from #87 plus merged changes since v1.1.3

Summary by CodeRabbit

  • New Features

    • Token and NFT collection details now accessible by tapping labels and logos to view address information.
  • Bug Fixes

    • Improved error handling when opening block explorer links with clearer failure messaging.
  • Chores

    • Version bumped to 1.1.4.
    • Enhanced Android app manifest configuration for improved HTTPS link handling.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026

📝 Walkthrough

Walkthrough

This PR releases v1.1.4 with interactive token and collection details. Users can now tap token symbols, logos, and collection names in the transaction simulation screen to view address details in a bottom sheet. Supporting improvements include better error handling in the address detail sheet's URL launcher and Android manifest configuration for HTTPS intent handling.

Changes

Interactive Token/Collection Details and v1.1.4 Release

Layer / File(s) Summary
AddressDetailSheet URL launching and flow improvements
lib/shared/widgets/address_detail_sheet.dart
The _handleExplorer method now dismisses the bottom sheet before attempting to open URLs, removes the canLaunchUrl pre-check, and handles the boolean result of launchUrl to show a failure snackbar instead of throwing exceptions.
Interactive token/collection details in simulation screen
lib/features/verify_safe_transaction/simulation/safe_tx_simulation_screen.dart
New import for AddressDetailSheet enables private helper methods (_showTokenDetail, _tokenLogo, _inlineTokenSpan, _inlineTappableLabelSpan) that render tappable, underlined token and collection spans. Token transfer, token allowance, revoked allowance, NFT transfer, NFT allowance, and revoked NFT allowance UI elements are updated to use these helpers, making all token/collection labels and logos tappable.
Platform configuration and release documentation
android/app/src/main/AndroidManifest.xml, pubspec.yaml, CHANGELOG.md
Android manifest adds an HTTPS intent to the queries section for URL handling, pubspec.yaml version is bumped to 1.1.4+9, and CHANGELOG.md is updated with v1.1.4 release notes and version history summary.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • candidelabs/safe-opensig#86: Modifies token logo rendering logic in safe_tx_simulation_screen.dart with fallback and error handling.
  • candidelabs/safe-opensig#83: Contains the same URL launching improvements in AddressDetailSheet._handleExplorer and Android manifest HTTPS intent addition.
  • candidelabs/safe-opensig#84: Introduces tappable token/collection labels and address detail bottom-sheet behavior in the simulation screen.

Suggested reviewers

  • Sednaoui

Poem

🐰 Tokens now tap, like carrots in a row,
Details bloom below, a sheet we fondly know,
Address labels dance with dotted lines so fine,
v1.1.4 hops across the finish line! 🥕✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title 'release: promote 1.1.4' clearly and specifically describes the main change — bumping the app version to 1.1.4 and updating the changelog, which aligns with the changeset's primary objective.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@lib/features/verify_safe_transaction/simulation/safe_tx_simulation_screen.dart`:
- Around line 266-275: The helper _showTokenDetail funnels taps into
AddressDetailSheet which assumes availableNetworks[chainId] exists and can crash
for unsupported/custom chains; before calling AddressDetailSheet, check that
widget.safeAccount.network.chainId is present in the networks map (or otherwise
supported) and only open the sheet when valid—if not, return early or show a
safe fallback (e.g., an error/snackbar) instead of opening AddressDetailSheet to
avoid the force-unwrap crash. Use the same chainId symbol
(widget.safeAccount.network.chainId) to locate the call site and gate it with a
containsKey/isSupported check against the app's network registry before creating
AddressDetailSheet.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7eea5e21-3070-4183-a233-c1291207c6d8

📥 Commits

Reviewing files that changed from the base of the PR and between 5caec45 and 54ff8af.

📒 Files selected for processing (5)
  • CHANGELOG.md
  • android/app/src/main/AndroidManifest.xml
  • lib/features/verify_safe_transaction/simulation/safe_tx_simulation_screen.dart
  • lib/shared/widgets/address_detail_sheet.dart
  • pubspec.yaml

@andrewwahid andrewwahid changed the title sync: develop into main release: promote 1.1.4 May 19, 2026
@Sednaoui Sednaoui merged commit adf4e93 into main May 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants