fix(oracle): use IPv6 subnet prefix for secondary VNIC addresses#6843
Open
qm3ster wants to merge 1 commit intocanonical:mainfrom
Open
fix(oracle): use IPv6 subnet prefix for secondary VNIC addresses#6843qm3ster wants to merge 1 commit intocanonical:mainfrom
qm3ster wants to merge 1 commit intocanonical:mainfrom
Conversation
On dual-stack secondary VNICs, the IPv6 address was incorrectly configured with the IPv4 subnet prefix length (e.g. /24 instead of /64). This happened because `network` was computed from `subnetCidrBlock` (IPv4) and reused for both address families.
|
Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close. If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging blackboxsw, and he will ensure that someone takes a look soon. (If the pull request is closed and you would like to continue working on it, please do tag blackboxsw to reopen it.) |
github-actions
Bot
added
the
stale-pr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On OCI instances with IPv6 enabled on a secondary VNIC,
_add_network_config_from_opc_imdsused a singlenetworkvariable (derived from the IPv4subnetCidrBlock) for both IPv4 and IPv6 prefix lengths. This caused the IPv6 address to be configured with the IPv4 prefix length.OCI's IMDS provides
ipv6SubnetCidrBlockwith the correct IPv6 prefix, but it was never read.The fix moves the
networkassignment inline to each address block, so IPv4 usessubnetCidrBlockand IPv6 usesipv6SubnetCidrBlock.