docs: make password lock explicit in users-groups example 3#6869
Open
0xdeadd wants to merge 1 commit intocanonical:mainfrom
Open
docs: make password lock explicit in users-groups example 3#68690xdeadd wants to merge 1 commit intocanonical:mainfrom
0xdeadd wants to merge 1 commit intocanonical:mainfrom
Conversation
The example3 description states 'Password-based login is rejected', but the YAML did not actually set lock_passwd. While true is the default, adding it explicitly removes the documentation gap that arose during review of canonical#6865 / canonical#6858. Suggested by @neitsab in canonical#6865 (comment)
github-actions
Bot
added
the
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commits
lock_passwd: truetodoc/module-docs/cc_users_groups/example3.yamlAdditional Context
Follow-up to #6865 (closed in favor of #6858). The merged #6858 fixed the discrepancy between
data.yamland the example by addingssh_import_idtoexample3.yaml, but the description still claims "Password-based login is rejected" withoutlock_passwd: trueappearing in the YAML.lock_passwd: trueis the default, so this is purely a documentation clarity change — readers comparing the example to the prose will now see all three claims (password rejection, SSH import, custom shell) reflected in the YAML.Suggested by @neitsab in #6865 (comment).
Test Steps
N/A — documentation example only. ReadTheDocs build verifies rendering.
Merge Type