fix(analyze): warn before GNU date fallback#6879
Open
nanookclaw wants to merge 3 commits into
Open
Conversation
Signed-off-by: Nanook <nanookclaw@users.noreply.github.com>
Signed-off-by: Nanook <nanookclaw@users.noreply.github.com>
holmanb
requested changes
Jun 12, 2026
holmanb
left a comment
holmanb
left a comment
Member
There was a problem hiding this comment.
Please fix comments and failing tests.
Comment on lines
-225
to
290
| SAMPLE_LOGS = dedent( | ||
| """\ | ||
| SAMPLE_LOGS = dedent("""\ | ||
| Nov 03 06:51:06.074410 x2 cloud-init[106]: [CLOUDINIT] util.py[DEBUG]:\ | ||
| Cloud-init v. 0.7.8 running 'init-local' at Thu, 03 Nov 2016\ | ||
| 06:51:06 +0000. Up 1.0 seconds. | ||
| 2016-08-30 21:53:25.972325+00:00 y1 [CLOUDINIT] handlers.py[DEBUG]: finish:\ | ||
| modules-final: SUCCESS: running modules for final | ||
| """ | ||
| ) | ||
| """) | ||
|
|
Member
There was a problem hiding this comment.
This formatting changes seem unrelated to this PR.
Author
|
Pushed Local verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a transitional warning when
cloud-init analyze dumpfalls back to GNUdate/gdatefor timestamp parsing. The warning includes the unrecognized timestamp format and the selected binary so maintainers can collect formats that still need native Python support before removing the shell-out path.The no-GNU-date behavior is unchanged: unsupported formats still raise
ValueErrorwhen neitherdatenorgdateis available.Fixes #4357.
Testing
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 pytest -q tests/unittests/analyze/test_dump.pygit diff --checkPlain
pytestin this environment auto-loads a missing external plugin (evalcraft), so I disabled plugin autoload for the focused test run.