test: apt resolute gpg remove accounts for gpg-from-sq#6902
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the apt integration test setup to prevent unintended installation of gpg-from-sq on newer Ubuntu releases when removing gpg, addressing CI failures in test_install_missing_deps.
Changes:
- Add release gating for the
gpgremoval user-data to also remove packages that would otherwise pull ingpg-from-sq. - Refactor the test user-data into a parameterized template and package lists to simplify per-release behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
holmanb
left a comment
There was a problem hiding this comment.
Please address the review comment. Otherwise this looks good.
62cc7cc to
cb9d467
Compare
|
Unrelated test failures resolved by #6908. |
holmanb
left a comment
There was a problem hiding this comment.
I left a nitpick, but this looks good to me.
bc24a6f to
83a8419
Compare
On resolute and newer, removal of gpg triggers the install of gpg-from-sq as an alternative for the metapkg if python3-software-properties or libgpgme45 are still installed. Ensure removal of the additional rdepends to avoid triggering installation of gpg-from-sq during the removal of gpg.
83a8419 to
c575968
Compare
Can we update this PR to get passing tests? |
@holmanb sure, can you please review canonical/pycloudlib#506 so our integration tests will be fixed? |
|
@holmanb pycloudlib version is now fixed per canonical/pycloudlib#509. re-running the integration tests now pass. This is ready for review now. |
Proposed Commit Message
Additional Context
Daily integration test failures in CI on test_missing_deps. Symptom is gpg was not seen as being re-installed after initial removal (because gpg-from-sq was added in it's place, as seen in /var/log/apt/term.log during initial test image creation)
Test Steps
Merge type