fix(init): exit parent template dir context after using it

[jonathan-conder]

The directory isn't guaranteed to exist after the context manager exits.

---

• Have you followed the guidelines for contributing?
• Have you signed the CLA?
• Have you successfully run make lint && make test?
• Have you added an entry to the changelog (docs/reference/changelog.rst)?

---

There were some unrelated lint/test failures.

[bepri]

Looks good, thanks for updating the tests too. Just one nit :)

[bepri]

Suggested change

	def parent_template_dir(self) -> AbstractContextManager[pathlib.Path]:
	@contextlib.contextmanager
	def parent_template_dir(self) -> pathlib.Path
	yield importlib.resources.path(self._app.name, "templates")

It's not letting me highlight the whole block for this suggestion (grr) so sorry if it looks weird. I would wrap this using a decorator instead, it's a more common pattern with our tools.

[lengau]

Under this example wouldn't it need to be something like:

with importlib.resources.path(...) as p:
    yield p

Otherwise you'd have a context manager that yields a context manager.

[bepri]

facepalm, yeah, that's correct

[jonathan-conder]

The return type isn't right, do you have any preferences between Iterator[pathlib.Path], Generator[pathlib.Path] or Iterable[pathlib.Path]?

I'll probably revisit this next week to add the back-compatibility.

[bepri]

I think Generator makes the most sense to me for something that's meant to be used as a context manager, but I don't have a strong preference

[lengau]

This is a breaking change, since a child class could override this. We might need to instead deprecate this method and add a new one with the right behaviour.

[jonathan-conder]

Ok I've attempted it. Probably not 100% compatible since the subclass could override __getattribute__ or something weird like that.

[medubelko]

Just a small suggestion for the changelog.