feat: spread tests and centralized justfile#9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings the rock up to speed with our newest practice of a centralized justfile, and changes our tests to use
rockcraft test(and thusspread).I'm adding spread tests to the latest folder only; feel free to copy-paste that to other versions if you want, but please do so in a follow-up PR!
Context
More information can be found at:
Per usual, you can also find the available commands by simply running
just.FAQ
.extensionfile? The.extensionfile is arockcraft init --profile=testartifact; unfortunately we can't remove it or avoid to commit itspread.yamlinstead of copying it injust test? Unfortunately not, asrockcraft test(which internally callsrockcraft packfirst) mounts the rock folder to a LXD container for packing, which breaks all symlinksTesting Instructions
just testwill run the tests for the latest rock version.Upgrade Notes
This PR won't trigger changes to any
rockcraft.yamlfile, which means::devtag