Skip to content

Validate garm configurator max runner#264

Merged
cbartz merged 8 commits into
mainfrom
fix-garm-configurator-max-runner-validation
Jul 6, 2026
Merged

Validate garm configurator max runner#264
cbartz merged 8 commits into
mainfrom
fix-garm-configurator-max-runner-validation

Conversation

@cbartz

@cbartz cbartz commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

What this PR does

Ensure max-runner is set to non-zero value

Why we need it

GARM rejects scalesets with max-runners=0

  if s.MaxRunners == 0 {
      return fmt.Errorf("max_runners cannot be 0")
  }

  Path: parts/garm/src/params/requests.go

Checklist

  • Changes comply with the project's coding standards and guidelines (see CONTRIBUTING.md and STYLE.md)
  • CONTRIBUTING.md has been updated upon changes to the contribution/development process (e.g. changes to the way tests are run)
  • Technical author has been assigned to review the PR in case of documentation changes (usually *.md files)
  • I updated docs/changelog.md with user-relevant changes
  • I used AI to assist with preparing this PR
  • I added or updated tests as needed (unit and integration)
  • If integration test modules are used: I updated the workflow configuration
    (e.g., in .github/workflows/integration_tests.yaml, ensure the modules list is correct)
  • If this PR involves a Grafana dashboard: I added a screenshot of the dashboard
  • If this PR involves Terraform: terraform fmt passes and tflint reports no errors
  • If this PR involves Rockcraft: I updated the version
  • If this PR adds/removes a charm, or changes a charm's base class, conventions, tooling, or repo structure: I updated the relevant AGENTS.md
  • If this PR changes .copilot-collections.yaml or .github/instructions/: I re-checked whether the AGENTS.md "12-factor divergences" guidance still matches the upstream copilot-collections guidance

@cbartz cbartz marked this pull request as ready for review July 6, 2026 06:05
Comment thread charms/garm-configurator/src/charm_state.py Outdated
@cbartz cbartz enabled auto-merge (squash) July 6, 2026 06:26
@cbartz cbartz merged commit 352c95a into main Jul 6, 2026
62 checks passed
@cbartz cbartz deleted the fix-garm-configurator-max-runner-validation branch July 6, 2026 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants