-
Notifications
You must be signed in to change notification settings - Fork 2
feat: dead letter mechanism for non-retryable messages #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
436f97f
add exchange declaration
cbartz fc43cc6
add exchange declaration to consumer
cbartz c658666
add queue bind
cbartz 2420d3e
add DefaultQueueConfig
cbartz ce15ff7
move MockAmqpChannel to mock_test.go
cbartz 51540a3
remove fakeChannel implementation
cbartz 7386373
fix planner main_test
cbartz 0037c88
fix webhook_test.go
cbartz 435b180
refactor webhook_test.go
cbartz e1de3b1
remove redundant comments
cbartz 0f61ffd
update CONTRIBUTING.md
cbartz 6ad783b
Merge branch 'main' into feat/use-exchange-ISD-4838
cbartz ecf7d6c
Update CONTRIBUTING.md
cbartz 20be461
add dead-letter queue for non-retryable messages
cbartz 11c8473
add unit tests
cbartz 9761c6e
add integration test
cbartz b667590
add one integration test using multiple scenarios
cbartz c21f3ad
refactor integration test
cbartz 706dca9
remove sleep
cbartz d41a89c
Merge branch 'main' into feat/dead-letter-ISD-4906
cbartz 71942d6
remove redundant comments
cbartz 2db4423
comply with STYLE guide
cbartz bad5d8e
remove redundant tests
cbartz dc4adf2
pin postgres 16.11
cbartz 0ce1183
change to debug log level for ignoring log messages
cbartz 7141b9a
getQueueDepthByName -> getNumMessagesInQueue
cbartz ba7a909
rename declare* functions to ensure* to clarify they are idempotent
cbartz 88dca58
Merge branch 'main' into feat/dead-letter-ISD-4906
cbartz a74ffb0
rename other functions to ensure* to clarify they are idempotent
cbartz 80efcf8
refactor: introduce getWorkflowJob for more obvious semantics
cbartz 6f2350c
add paranoia check
cbartz 9fc75d2
fix ci
cbartz f8ecaed
Merge branch 'main' into feat/dead-letter-ISD-4906
cbartz 716de1e
improve log warning
cbartz a3005fc
Merge remote-tracking branch 'origin/feat/dead-letter-ISD-4906' into …
cbartz d5aeae2
wait for queue to avoid race condition where queue is not existent
cbartz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.