fix: Use lscpu to detect lack of confinement#400
Open
farshidtz wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates snap confinement detection used by use-engine --auto to decide whether hardware information can be collected (and thus whether --fallback should be used), replacing a sysfs-based heuristic with an lscpu-based check due to changed interface permissions.
Changes:
- Add an
lscpuexecution check inHardwareObservable()as a proxy for “installed without confinement”. - Remove the previous
/sys/bus/pci/devicesdirectory-read heuristic that is no longer reliable.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto engine selection is expected to use the set fallback when there is no access to detect the hardware. The fallback logic is broken since the auto-connected opengl interface now grants access to read
/sys/bus/pci/devices. This path was being checked to assume unconfined installation, which now produces a false positive (hardware-observe not connected, confined installation) and result in errors while reading USB devices.This PR changes the logic and relies on lscpu command instead, similar to how it was being done before implementing the --fallback flag. This now improved to run lscpu with the absolute system path so that staging
util-linuxwhich adds lscpu at$SNAP/usr/bin/lscpuwon't get around it.