Extend test job condition to check build completion#69
Open
farshidtz wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the reusable PR build/test workflow so the test job only runs when the build-and-publish job has actually completed successfully (or was intentionally skipped because an existing successful build was detected), preventing tests from running after a build timeout.
Changes:
- Tightens the
testjob condition to requirebuild-and-publishresult to besuccessorskipped(instead of “not failed”). - Updates job comments to reflect the intended behavior around build completion vs. skipping.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
122
to
+126
| needs: [build-and-publish] | ||
| # Run only for trigger-tests label, not any other label | ||
| # Run even if previous job was skipped (!cancelled) | ||
| # Run only if build hasn't failed | ||
| if: ${{ inputs.trigger-label == 'trigger-tests' && !cancelled() && needs.build-and-publish.result != 'failed' }} | ||
| # Run only if build completed successfully or was skipped due to pre-check | ||
| if: ${{ inputs.trigger-label == 'trigger-tests' && !cancelled() && (needs.build-and-publish.result == 'success' || needs.build-and-publish.result == 'skipped') }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test job currently runs even if build-and-publish has timed out after 6 hours.
The PR reverts to condition to how it was prior to #65