Add missing yaml tags#24
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds missing yaml struct tags to several device model types so that YAML serialization uses the same field names as existing JSON serialization (e.g., bus-number, vendor-id) and supports inlining embedded “friendly name” fields.
Changes:
- Added
yaml:"..."tags to USB, PCI, and FastRPCDevicestructs to mirror existing JSON tag naming. - Added
yaml:",inline"tags for embeddedFriendlyNamesto support flattened YAML output. - Added YAML tags (including
omitempty) for friendly-name pointer fields andAdditionalProperties.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/machine/device/usb/usb.go | Adds YAML tags for USB device fields and friendly-name inlining. |
| pkg/machine/device/pci/pci.go | Adds YAML tags for PCI device fields, optional fields, and friendly-name inlining. |
| pkg/machine/device/fastrpc/fastrpc.go | Adds YAML tags for FastRPC device fields and additional properties. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
farshidtz
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.