Add format flag#26
Open
mrmara wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a --format CLI flag to lscompute to support multiple output serializations, making the default output a human-readable “plain” summary while preserving JSON output for machine consumption.
Changes:
- Add
--formatflag to selectplain(default) orjsonoutput. - Introduce
pkg/machineformatting layer (Marshal) with a plain-text renderer. - Update usage documentation and add example-based tests for both formats.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| README.md | Updates usage docs to describe default plain output and --format flag. |
| cmd/lscompute/main.go | Adds flag parsing and routes output through machine.Marshal. |
| pkg/machine/format.go | Implements format selection + plain-text rendering and byte formatting helpers. |
| pkg/machine/format_test.go | Adds Go examples for JSON and plain output rendering using test data. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
farshidtz
reviewed
Jul 8, 2026
farshidtz
reviewed
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usage:
lscompute --format plain|jsonplainformat is defaultExaple Output: