fix(maasserver): avoid sources_list when >=24.04#45
Draft
AloizioMacedo wants to merge 10 commits intocanonical:masterfrom
Draft
fix(maasserver): avoid sources_list when >=24.04#45AloizioMacedo wants to merge 10 commits intocanonical:masterfrom
AloizioMacedo wants to merge 10 commits intocanonical:masterfrom
Conversation
This leverages the fact that cloud-init will populate ubuntu.sources if given a deb822-formatted string, as seen in https://docs.cloud-init.io/en/latest/reference/yaml_examples/apt.html
Also include a test for get_ubuntu_version itself
Contributor
Author
|
This is on hold for a while, as we need to wait for some changes in Curtin so that this can work with deployments in disk. |
Member
Maybe worth moving into a Draft PR until Curtin is fixed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From Ubuntu 24.04 forward, the apt repository is now stored by default following the deb822 format. See here for a reference: https://repolib.readthedocs.io/en/latest/deb822-format.html
Before this change, machines would end up having both the old one-line format on top of the deb822, generating two repository sources as described in https://bugs.launchpad.net/maas/+bug/2093303.
This PR empties the old one in case we are deploying a machine with Ubuntu >=24.04.