Cluster manager reverse tunnel#801
Open
edlerd wants to merge 1 commit into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
edlerd
force-pushed
the
websocket
branch
7 times, most recently
from
1d36035 to
e4741bd
Compare
Contributor
|
@edlerd can this PR be closed? |
Contributor
Author
We might want to use this approach at a later time, so I'd keep it open in draft state. |
edlerd
force-pushed
the
websocket
branch
3 times, most recently
from
99939f7 to
0f73e50
Compare
edlerd
force-pushed
the
websocket
branch
6 times, most recently
from
03a8fa9 to
99d12b3
Compare
edlerd
force-pushed
the
websocket
branch
3 times, most recently
from
8988de9 to
f1f9f2f
Compare
edlerd
changed the title
edlerd
force-pushed
the
websocket
branch
4 times, most recently
from
1f74f54 to
79d3180
Compare
roosterfish
requested changes
Jun 10, 2026
roosterfish
left a comment
roosterfish
left a comment
Contributor
There was a problem hiding this comment.
Hi, thanks for this. I have left a few comments on the spec and here, mainly around how we spawn and manage the tunnel routine as well as some inconsistencies I have spotted between setting various cluster manager configs on the CLI compared to the underlying struct fields.
Contributor
|
Also can you please extend the cluster manager test suite to test the tunnel? |
| Timeout: 30 * time.Second, | ||
| } | ||
|
|
||
| lxdResponse, err := lxdHttpClient.Do(newReq) |
edlerd
force-pushed
the
websocket
branch
2 times, most recently
from
6bbe407 to
7a910a3
Compare
Contributor
Author
Added some basic tests for setting / unsetting. To test the whole tunnel feature set, we'd need a full cluster manager in CI. |
edlerd
force-pushed
the
websocket
branch
4 times, most recently
from
c08ac56 to
7201339
Compare
edlerd
force-pushed
the
websocket
branch
2 times, most recently
from
41d2261 to
fdbbad7
Compare
Signed-off-by: David Edler <david.edler@canonical.com>
Contributor
Author
|
@roosterfish please have another look at this, all comments above should be resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
Ready for review.