Conversation
| --overlay ./storage-small-overlay.yaml | ||
| ``` | ||
|
|
||
| (deploy-cos-ref)= |
There was a problem hiding this comment.
Iirc we haven't started using these our docs yet.
Remind me - it's an anchor or cross-sphinx ref?
I think juju had this and it turned out to be brittle and difficult to maintain, but maybe I'm missing something.
There was a problem hiding this comment.
It's an anchor, but it can also be used as a cross-sphinx/project ref for projects that have that enabled.
You haven't started using them in the COS docs yet, but it is the standard approach to cross-linking for sphinx docs projects, so at some point, you should change your links to use these refs. Juju uses them in their docs, but I don't know what conversations happened around it
Using ref targets/anchors is nicer because otherwise anytime you change the filename/path, it'll break any of those links in your docs.
IMO, it could go either way in this PR (add it or don't add it), but the future goal should be that all docs have a ref target, and you use those for linking instead of file path. (Copilot should be able to handle it well when you do make this initiative)
| ```diff | ||
| + http = { | ||
| + source = "hashicorp/http" | ||
| + version = "~> 3.0" | ||
| + } | ||
| ``` |
There was a problem hiding this comment.
Do we need to sepcify http here? Can it be a derived dependency from the charmhub module?
|
Hi @YanisaHS, could you please review this PR with me? I would appreciate some opinions on the clarity and structure of the document. |
|
@MichaelThamm Yea, I'd be happy to! 😊 I likely won't have time to review it until Tuesday though (I'm off Monday) |
@YanisaHS This PR is still a work in progress. It may be best to wait until I make some more progress before reviewing this PR. The docs still need updating before first review. |
|
@MichaelThamm Ok, sounds good! Just tag me when you're ready again |
|
I think it is ready for review now: docs link Some input I would like from you is:
I need to add a comment to the doc about not guaranteed to work across tracks. |
|
@MichaelThamm Ok! I'll review it soon (was off the end of last week) |
|
@MichaelThamm I'll go through and actually provide feedback in the doc, but first addressing your two issues:
For a tutorial, this is fine. I'd still recommend you add a note (as you suggested) describing this condition, mostly for any driveby users / people who find this without realizing they're in a Diataxis ✨ tutorial ✨. Tutorials are more of a "sandboxed" experience, so it's okay to feed the user the configurations they need. But...
Yes. The Tutorials section in the Observability docs gives the docs in order a new user should follow, so now it reads like (1) Deploy, (2) Refresh, (3) Sync .. etc. The experience feels odd for a new user - if it's important they're on this track, then that should be given to them in the previous Deploy steps, rather than deploying and refreshing right after. Actually this is something we'll discuss as a team this cycle: From a user's perspective, one of the most immediate concerns I have with the docs is that they don't clearly state how to deploy COS in the How-to guides (examples: Charmed Kafka, Charmed Postgres, Charmed K8s). When this is the first thing a user needs to do to access the product (and rest of the documentation). I'll provide feedback with this in mind as I go through your PR - assuming you'll refactor it into a how-to guide. |
YanisaHS
left a comment
There was a problem hiding this comment.
I was mostly just looking at the Refresh product module doc, although I quick scanned the README and didn't have any comments. If you want me to provide feedback on something else in the PR then LMK
| --overlay ./storage-small-overlay.yaml | ||
| ``` | ||
|
|
||
| (deploy-cos-ref)= |
There was a problem hiding this comment.
It's an anchor, but it can also be used as a cross-sphinx/project ref for projects that have that enabled.
You haven't started using them in the COS docs yet, but it is the standard approach to cross-linking for sphinx docs projects, so at some point, you should change your links to use these refs. Juju uses them in their docs, but I don't know what conversations happened around it
Using ref targets/anchors is nicer because otherwise anytime you change the filename/path, it'll break any of those links in your docs.
IMO, it could go either way in this PR (add it or don't add it), but the future goal should be that all docs have a ref target, and you use those for linking instead of file path. (Copilot should be able to handle it well when you do make this initiative)
| @@ -0,0 +1,111 @@ | |||
| # Refresh COS to a new channel | |||
|
|
|||
| In this example, you will learn how to deploy COS Lite and refresh from channel `2/stable` to `2/edge`. To do this, we can deploy COS Lite via Terraform in the same way as [in the tutorial](https://documentation.ubuntu.com/observability/track-2/tutorial/installation/cos-lite-microk8s-sandbox). | |||
There was a problem hiding this comment.
Assuming this gets refactored into a tutorial, the language/framing should change so it's not like "In this example, you'll learn...". How-to guides aren't really "learning" experiences, it's more just like "here's the steps you need to do XYZ".
Example: Charmed Kafka: How to upgrade
|
|
||
| - Know how to deploy {ref}`COS Lite with Terraform <deploy-cos-ref>` | ||
|
|
||
| ## Introduction |
There was a problem hiding this comment.
Similar to a comment I made above, this section can be less narrative if being refactored into a how-to guide
(btw I'm happy to meet and discuss my comments with you if you want!)
| terraform apply | ||
| ``` | ||
|
|
||
| At this point, you will have successfully upgraded COS Lite from `2/stable` to `2/edge`! |
There was a problem hiding this comment.
The steps overall seem fine and pretty straightforward. I can provide some better feedback once it gets refactored into a how-to
|
Blocked by this issue: |
* Separates the storage directives for different worker roles Signed-off-by: Bartlomiej Gmerek <bartlomiej.gmerek@canonical.com> * chore: TODOs for tests * Separates storage directives for Tempo workers Signed-off-by: Bartlomiej Gmerek <bartlomiej.gmerek@canonical.com> * Separates storage directives for Tempo workers Signed-off-by: Bartlomiej Gmerek <bartlomiej.gmerek@canonical.com> * Cleans up after testing Signed-off-by: Bartlomiej Gmerek <bartlomiej.gmerek@canonical.com> --------- Signed-off-by: Bartlomiej Gmerek <bartlomiej.gmerek@canonical.com> Co-authored-by: Michael Thamm <mike.thamm@canonical.com>
This PR fixes #188 Signed-off-by: Jose C. Massón <939888+Abuelodelanada@users.noreply.github.com>
…nd versioning (#217) * docs: add explanation for dashboard upgrades and version dedup behavior * add "dedup*" to custom wordlist --------- Signed-off-by: Leon <82407168+sed-i@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: sed-i <82407168+sed-i@users.noreply.github.com>
juju_charmdatasource i.e., noupgrades.tffile, or only one if there is a breaking change i.e., aupgrades.tffile.Blocked by:
This PR will need coordination with:
Relates to:
Issue
We want a smooth UX between the TF provider and the Juju client for upgrading the product's channels.
Solution
juju_charmdatasource to provide the latest revisions for a charm in a specific track.lifecycle {replace_triggered_by = [terraform_data.grafana_ingress_interface]}to replace thejuju_integrationin the event that the interface changes.Checklist
Context
In the future charms will have unique tracks which the products needs to map to:
Testing Instructions
COS Lite manual
2/stabledev/edge2/stableDocumentation
See the CI job for the documentation changes