Open
Conversation
Author
|
An example showing that glob does not work in the CI is https://github.com/canonical/postfix-relay-operators/actions/runs/21898626334/job/63220750701. Note that although $ make vale
--- Syncing Vale styles... ---
Syncing pfe-vale [1/1] ███████████████████████████████████████████████ 100% | 0s
SUCCESS Synced 1 package(s) to '/home/raychan/Scratchspace/postfix-relay-operators/.vale/styles'.
--- Running Vale checks on "./**/*.md"... ---
postfix-relay-configurator-operator/CONTRIBUTING.md
7:115 error The word 'configurator' seems Canonical.000-US-spellcheck
to be misspelled.
✖ 1 error, 0 warnings and 0 suggestions in 4 files.
make: *** [Makefile.docs:56: vale] Error 1 |
Author
|
cc @erinecon |
Contributor
Test results for commit 0854108Test coverage for 0854108 Static code analysis report |
Contributor
Test results for commit 0854108Test coverage for 0854108 Static code analysis report |
Contributor
Test results for commit 0854108Test coverage for 0854108 Static code analysis report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applicable spec:
Overview
Support
vale-flagsinput fordocs.yamlworkflow, and default to--glob=*.md.Rationale
The
filesinput parameter in action-vale does not support globing, we need to usevale_flagsto do globing. This feature may be useful in monorepo setup where you have some markdown files also in the charm directory. Using this flag (e.g.--glob=*.md) can avoid running vale on python files.Workflow Changes
Checklist
urgent,trivial,complex)