[MISC] Merge service definitions#36
Merged
sinclert-canonical merged 4 commits intomainfrom Mar 11, 2026
Merged
Conversation
sinclert-canonical
added
the
not bug or enhancement
sinclert-canonical
force-pushed
the
sinclert/merge-services-definition
branch
from
96447e2 to
e7d322a
Compare
sinclert-canonical
requested review from
carlcsaposs-canonical,
dragomirp,
juju-charm-bot,
marceloneppel and
taurus-forever
and removed request for
a team
carlcsaposs-canonical
approved these changes
Mar 11, 2026
marceloneppel
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies the CI setup by leveraging the already existing Docker Compose files, instead of defining the services using GitHub Actions limited syntax. An additional benefit of avoiding GitHub Actions native syntax is that the services
command/entrypointsections can now be overridden at will (see GHA limitation)Additional changes