tls: add sunbeam cluster refresh manual-tls-certificates-operator com…#715
tls: add sunbeam cluster refresh manual-tls-certificates-operator com…#715hemanthnakkina wants to merge 1 commit into
Conversation
4924b9d to
9516405
Compare
|
LGTM overall. The only concern I have is allowing switching channels using the manifest. For example, I deployed |
Thanks for the review! In these specific commands for INFRA_APPS we should be supporting switching channels. I will try the other way round and see what happens i.e., switching from latest/stable to 1/stable |
…mand
- Add MANUAL_TLS_CERTIFICATES_CHANNEL constant to versions.py and replace
hardcoded "1/stable"/"latest/stable" strings in tls/ca.py,
tls/common.py and tls/vault.py
- Add manual-tls-certificates to INFRA_APPS so the generic
LatestInChannel refresh skips it
- Add ManualTLSCharmUpgradeStep (steps/manual_tls.py) using the shared
check_charm_needs_refresh helper (charm_upgrade.py) which:
- Skips if the app is not deployed
- Skips if already at the manifest-pinned revision
- Skips if already at the latest revision on the effective channel
- Returns FAILED for invalid/downgrade channel in manifest
- Passes --channel to charm_refresh only when the channel actually
changes (avoids unintended track switches on patch upgrades)
- Waits for active via wait_until_active (catches JujuWaitException
in addition to TimeoutError)
- Updates terraform tfvars after refresh
- Add `sunbeam cluster refresh manual-tls-certificates-operator`
subcommand with optional -m/--manifest flag
- Add unit tests covering all skip/run branches
9516405 to
4c9f4d9
Compare
…mand
sunbeam cluster refresh manual-tls-certificates-operatorsubcommand with optional -m/--manifest flag