fix: grant access for observability model to other nodes#794
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a cluster access gap when the observability feature is enabled by ensuring Juju model permissions are granted more broadly across nodes, including retroactively for existing nodes and for nodes joining later.
Changes:
- Update
sunbeam local addto grant the newly created Juju user access to all Juju models (based onjuju models --alloutput). - Extend Observability feature
post_enable()to grant all existing cluster nodes access to the Observability model. - Add unit tests covering dynamic model grants on node add and post-enable grant behavior for Observability.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| sunbeam-python/sunbeam/provider/local/commands.py | Builds grant steps for all Juju models when adding a node. |
| sunbeam-python/sunbeam/features/observability/feature.py | Grants Observability model access to all existing cluster nodes during post_enable(). |
| sunbeam-python/tests/unit/sunbeam/provider/local/test_commands.py | New tests verifying model access is granted for all models on node add. |
| sunbeam-python/tests/unit/sunbeam/features/test_observability.py | New tests verifying post-enable grant logic and failure tolerance. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+886
to
+889
| # Grant all existing Juju users access to the observability model | ||
| client = deployment.get_client() | ||
| jhelper = JujuHelper(deployment.juju_controller) | ||
|
|
Member
Author
|
Waiting for #791 to be merged |
Closes-Bug: #2041610 Signed-off-by: Himawan Winarto <himawan.winarto@canonical.com>
hemanthnakkina
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
observabilityfeature is enabled, other node in the cluster or any new node joining the cluster will not have access to the Juju model.This PR fixes the issue by granting access to the Observability model for all nodes currently in the cluster and retroactively grating new node joining the cluster the access to all Juju models.
Closes-Bug: #2041610