Skip to content

storage: add Dell Unity and Huawei Dorado backends#805

Open
ahmad-can wants to merge 2 commits into
canonical:mainfrom
ahmad-can:feature/generate-charm-dell-unity-and-huawei-dorado
Open

storage: add Dell Unity and Huawei Dorado backends#805
ahmad-can wants to merge 2 commits into
canonical:mainfrom
ahmad-can:feature/generate-charm-dell-unity-and-huawei-dorado

Conversation

@ahmad-can
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds two new Cinder storage backend implementations—Dell Unity and Huawei OceanStor Dorado—to Sunbeam’s storage backend plugin system, along with unit tests and pytest fixtures to validate their configuration models and metadata.

Changes:

  • Added DellunityBackend and HuaweiBackend implementations with corresponding StorageBackendConfig subclasses.
  • Added unit tests covering backend identity metadata and config validation behavior for both backends.
  • Extended the storage backend unit-test fixtures/registry to include the new backend types.

Reviewed changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
sunbeam-python/sunbeam/storage/backends/dellunity/backend.py New Dell Unity backend + config model.
sunbeam-python/sunbeam/storage/backends/dellunity/init.py Package initializer for the Dell Unity backend module.
sunbeam-python/sunbeam/storage/backends/huawei/backend.py New Huawei OceanStor Dorado backend + config model (incl. HyperMetro fields).
sunbeam-python/sunbeam/storage/backends/huawei/init.py Package initializer for the Huawei backend module.
sunbeam-python/tests/unit/sunbeam/storage/backends/conftest.py Adds fixtures and registers the new backend classes in the test backend map.
sunbeam-python/tests/unit/sunbeam/storage/backends/test_dellunity.py New unit tests for Dell Unity backend/config validation.
sunbeam-python/tests/unit/sunbeam/storage/backends/test_huawei.py New unit tests for Huawei backend/config validation (incl. HyperMetro fields).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread sunbeam-python/sunbeam/storage/backends/dellunity/backend.py
Comment thread sunbeam-python/sunbeam/storage/backends/dellunity/backend.py Outdated
Comment thread sunbeam-python/sunbeam/storage/backends/huawei/backend.py
Comment thread sunbeam-python/sunbeam/storage/backends/huawei/backend.py Outdated
@ahmad-can ahmad-can force-pushed the feature/generate-charm-dell-unity-and-huawei-dorado branch from bc2d57b to 52a0a7b Compare June 2, 2026 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants