storage: add Dell Unity and Huawei Dorado backends#805
Open
ahmad-can wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds two new Cinder storage backend implementations—Dell Unity and Huawei OceanStor Dorado—to Sunbeam’s storage backend plugin system, along with unit tests and pytest fixtures to validate their configuration models and metadata.
Changes:
- Added
DellunityBackendandHuaweiBackendimplementations with correspondingStorageBackendConfigsubclasses. - Added unit tests covering backend identity metadata and config validation behavior for both backends.
- Extended the storage backend unit-test fixtures/registry to include the new backend types.
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| sunbeam-python/sunbeam/storage/backends/dellunity/backend.py | New Dell Unity backend + config model. |
| sunbeam-python/sunbeam/storage/backends/dellunity/init.py | Package initializer for the Dell Unity backend module. |
| sunbeam-python/sunbeam/storage/backends/huawei/backend.py | New Huawei OceanStor Dorado backend + config model (incl. HyperMetro fields). |
| sunbeam-python/sunbeam/storage/backends/huawei/init.py | Package initializer for the Huawei backend module. |
| sunbeam-python/tests/unit/sunbeam/storage/backends/conftest.py | Adds fixtures and registers the new backend classes in the test backend map. |
| sunbeam-python/tests/unit/sunbeam/storage/backends/test_dellunity.py | New unit tests for Dell Unity backend/config validation. |
| sunbeam-python/tests/unit/sunbeam/storage/backends/test_huawei.py | New unit tests for Huawei backend/config validation (incl. HyperMetro fields). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bc2d57b to
52a0a7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.