fix: properly granting observability model access to Juju users#809
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to fix observability model permission grants in MAAS deployments where a single Juju user is shared across nodes (so granting access by node hostname is incorrect).
Changes:
- Switch post-enable access grants from iterating cluster nodes to iterating Juju users.
- Update the username used for
JujuGrantModelAccessStepand related warning logs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
887
to
+891
| # Grant all existing Juju users access to the observability model | ||
| client = deployment.get_client() | ||
| jhelper = JujuHelper(deployment.juju_controller) | ||
|
|
||
| for node in client.cluster.list_nodes(): | ||
| node_name = node["name"] | ||
| for user in client.cluster.list_juju_users(): |
Member
Author
There was a problem hiding this comment.
This is the intended change.
In MAAS deployment, one Juju user is shared across all of the nodes. Previously, we use the nodes' names to grant access. Closes-Bug: #2155095 Signed-off-by: Himawan Winarto <himawan.winarto@canonical.com>
hemanthnakkina
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In MAAS deployment, one Juju user is shared across all of the nodes. Previously, we use the nodes' names to grant access.
Closes-Bug: #2155095