Skip to content

Only set TMPDIR while running tests #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dosaboy merged 1 commit into from
Jun 17, 2026
Merged

Only set TMPDIR while running tests #404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions openstack/tools/charmed_openstack_functest_runner.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ run_test_phase ()
local target=
local alias=
local bundle=
local _tmpdir_save=

unit_errors=$(juju status --format json| jq '.applications[]| select(.units!=null)| .units[]."workload-status"| select(.current=="error")')
if [[ -n $unit_errors ]]; then
Expand All @@ -104,7 +105,10 @@ run_test_phase ()
fi
fi

_tmpdir_save=${TMPDIR:-}
export TMPDIR=$TESTS_TMPDIR
functest-$phase -m $model ${args}
export TMPDIR=$_tmpdir_save
ret=$?
deactivate
return $ret
Expand Down Expand Up @@ -264,7 +268,7 @@ export TEST_JUJU3=1
export TEST_ZAZA_BUG_LP1987332=1

# Juju 3.x is a confined snap so cannot read/write from/to /tmp. This makes the tests use a path that juju can read/write.
export TMPDIR=$(mktemp -d ${HOME}/charm-functests-tmp-XXXX)
TESTS_TMPDIR=$(mktemp -d ${HOME}/charm-functests-tmp-XXXX)

# Some charms point to an upstream constraints file that installs python-libjuju 2.x so we need to do this to ensure we get 3.x
# NOTE: we only do this if we are using Juju >= 3.x
Expand Down Expand Up @@ -390,6 +394,8 @@ for target in ${func_target_order[@]}; do
[[ -d src ]] && pushd src &>/dev/null || true
fail=false
_target="$(python3 $TOOLS_PATH/extract_job_target.py $target)"
_tmpdir_save=${TMPDIR:-}
export TMPDIR=$TESTS_TMPDIR
if ! $MANUAL_FUNCTESTS; then
tox ${tox_args} -- $_target || fail=true
model=$(juju list-models| egrep -o "^zaza-\S+"|tr -d '*')
Expand All @@ -398,6 +404,7 @@ for target in ${func_target_order[@]}; do
model=test-$target
init_noop_target=false
fi
export TMPDIR=$_tmpdir_save

$fail && retry_on_fail "$model" "$target" && fail=false
if $fail; then
Expand Down Expand Up @@ -437,7 +444,6 @@ fi
) 2>&1 | tee $LOGFILE
echo -e "\nResults also saved to $LOGFILE"

if [ -d $TMPDIR ]; then
rm -rf $TMPDIR
unset TMPDIR
if [ -d $TESTS_TMPDIR ]; then
rm -rf $TESTS_TMPDIR
fi
Loading